Repository navigation
Unescape backslash-escaped quotes in link and image titles - #778
Open
SwastikTripathi wants to merge 2 commits into
Open
SwastikTripathi wants to merge 2 commits into
SwastikTripathi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A backslash-escaped quote in a link or image title comes out as a literal
"in the tooltip:The same happens in reference definitions (
[ref]: http://x "Say \"hi\"") and image titles."isn't in markdown2's backslash-escape table, so the title reaches_xml_escape_attrasSay \"hi\"and becomesSay \"hi\". The escaped-ampersand handling then reads\"as an escaped&and writes".The title now has
\"and\'turned into plain quotes before it is escaped for the attribute, so they come out as"and'. Titles without a backslash are untouched.New case
link_title_escaped_quotescovers an inline link, a single-quoted title with\', a reference link and an image. It fails before the change and passes after. The rest of the suite is unchanged (the same 14 known failures as on master).Separate from this: with the
smarty-pantsextra, the same title comes out astitle="Say "hi"", both before and after this change, because\"is swapped for a placeholder earlier on that path. I left that alone here.